-
Notifications
You must be signed in to change notification settings - Fork 1.8k
RHDEVDOCS-6488: creating build with buildpacks #95748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: build-docs-main
Are you sure you want to change the base?
RHDEVDOCS-6488: creating build with buildpacks #95748
Conversation
@deerskindoll: This pull request references RHDEVDOCS-6488 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Tue Jul 15 10:12:52 - Prow CI generated the docs preview: https://95748--ocpdocs-pr.netlify.app/openshift-builds/latest/work_with_builds/using-builds.html |
@deerskindoll: This pull request references RHDEVDOCS-6488 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ayushsatyam146 please have a look |
* You have created the project where your final application image will be stored by using the command `oc new-project buildpacks-example`. | ||
* Optional: You have installed the `shp` CLI. | ||
|
||
.Procedure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Procedure from here till line 58 is only needed if someone wants to use buildpacks with shp
cli. For using buildpacks or any other ClusterBuildStrategy in Builds for Openshift via oc cli these steps are not required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can put a NOTE for this and mention that these steps are optional and only needed with shp cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the doc. let me know if it's ok now.
+ | ||
[source,terminal] | ||
---- | ||
$ shp build create buildpack-nodejs-build \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for reference, this is the main command due to which we have to give permissions and follow extra steps if we wanna use shp cli.
@deerskindoll: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s):
build-docs-main, build-docs-1.5
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-6488
Link to docs preview:
https://95748--ocpdocs-pr.netlify.app/openshift-builds/latest/work_with_builds/using-builds#ob-creating-a-buildpacks-build_using-builds
QE review:
builds has no QE team available
Additional information: